[coreboot-gerrit] Change in coreboot[master]: mainboard/intel/galileo: Add SD controller configuration

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19212 )

Change subject: mainboard/intel/galileo: Add SD controller configuration
......................................................................


Patch Set 11:

(3 comments)

https://review.coreboot.org/#/c/19212/11/src/mainboard/intel/galileo/Kconfig
File src/mainboard/intel/galileo/Kconfig:

Line 25: 
add select DRIVERS_STORAGE_SD here, or default it to on below?


PS11, Line 182:  ENABLE_SD_TESTING
if not adding the select above, add depends on DRIVERS_STORAGE_SD here?


https://review.coreboot.org/#/c/19212/11/src/mainboard/intel/galileo/Makefile.inc
File src/mainboard/intel/galileo/Makefile.inc:

PS11, Line 22: y
$(CONFIG_DRIVERS_STORAGE_SD)?


-- 
To view, visit https://review.coreboot.org/19212
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf4faa40fe01eca98abffa2681f61fd8e059f0c4
Gerrit-PatchSet: 11
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes