[coreboot-gerrit] Change in coreboot[master]: vendorcode/amd/pi/00670F00: Clarify CAR disable

[Marshall Dawson (Code Review)]

Hello Kyösti Mälkki, Aaron Durbin, build bot (Jenkins), Martin Roth,

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/18492

to look at the new patch set (#16).

Change subject: vendorcode/amd/pi/00670F00: Clarify CAR disable
......................................................................

vendorcode/amd/pi/00670F00: Clarify CAR disable

Clean up the AMD_DISABLE_STACK_FAMILY_HOOK_F15 to be clear that
it does a wbinvd to preserve the coreboot stack and CAR globals.
The Stoney Ridge uses a different S3 architecture, so this is not
an issue of reserving or relocating the stack on a resume. Remove
the Gardenia cache_disable TODO comment as this clarifies how it
works for Stoney.

Change-Id: I77e53262212e00bce9145b0bc3909ad8651f2328
Signed-off-by: Marc Jones <marcj303 at gmail.com>
Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
---
M src/cpu/amd/pi/cache_as_ram.inc
M src/mainboard/amd/bettong/romstage.c
M src/mainboard/amd/db-ft3b-lc/romstage.c
M src/mainboard/amd/gardenia/romstage.c
M src/mainboard/amd/lamar/romstage.c
M src/mainboard/amd/olivehillplus/romstage.c
M src/mainboard/bap/ode_e21XX/romstage.c
M src/mainboard/pcengines/apu2/romstage.c
M src/vendorcode/amd/pi/00630F01/binaryPI/gcccar.inc
M src/vendorcode/amd/pi/00660F01/binaryPI/gcccar.inc
M src/vendorcode/amd/pi/00670F00/binaryPI/gcccar.inc
M src/vendorcode/amd/pi/00730F01/binaryPI/gcccar.inc
12 files changed, 116 insertions(+), 39 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/18492/16
-- 
To view, visit https://review.coreboot.org/18492
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I77e53262212e00bce9145b0bc3909ad8651f2328
Gerrit-PatchSet: 16
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Zheng Bao <fishbaozi at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>