[coreboot-gerrit] Change in coreboot[master]: intel/common/block/i2c: Add common block for I2C

[Rizwan Qureshi (Code Review)]

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/19468 )

Change subject: intel/common/block/i2c: Add common block for I2C
......................................................................


Patch Set 11:

> > So you never removed the other code in this patch series? Why?
 > the
 > > soc code is already using common code. Just change the Kconfig
 > > selections.
 > 
 > I suggest you either squash all the patches together or tweak the
 > existing code and then *move* it in a follow up patch. The reason I
 > say that is because I don't want to lose the history of the
 > existing code. The way you are transitioning the history be lost
 > and simple git blame won't tell us anything pertinent.

Aah...I get it.

-- 
To view, visit https://review.coreboot.org/19468
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d91a04c22e181e3a995112cce6d5f0324130b81
Gerrit-PatchSet: 11
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: No