[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Remove unused skylake_i2c_config structure

Furquan Shaikh (Code Review) gerrit at coreboot.org
Thu May 4 18:58:25 CEST 2017


Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/19520 )

Change subject: soc/intel/skylake: Remove unused skylake_i2c_config structure
......................................................................


soc/intel/skylake: Remove unused skylake_i2c_config structure

Remove struct skylake_i2c_config from chip.h since it is not used
anymore.

Change-Id: Icde4b7af5b9c31020099c1a6372a6867827f61ae
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
Reviewed-on: https://review.coreboot.org/19520
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Aaron Durbin <adurbin at chromium.org>
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
---
M src/soc/intel/skylake/chip.h
1 file changed, 0 insertions(+), 9 deletions(-)

Approvals:
  Aaron Durbin: Looks good to me, approved
  Sumeet R Pawnikar: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  build bot (Jenkins): Verified



diff --git a/src/soc/intel/skylake/chip.h b/src/soc/intel/skylake/chip.h
index cd461d4..b474ca2 100644
--- a/src/soc/intel/skylake/chip.h
+++ b/src/soc/intel/skylake/chip.h
@@ -40,15 +40,6 @@
 	I2C_VOLTAGE_1V8
 };
 
-struct skylake_i2c_config {
-	/* Bus speed in Hz, default is I2C_SPEED_FAST (400 KHz) */
-	enum i2c_speed speed;
-	/* Bus should be enabled prior to ramstage with temporary base */
-	int early_init;
-	/* Custom bus speed configuration { scl_lcnt, scl_hcnt, sda_hold } */
-	struct lpss_i2c_speed_config speed_config[LPSS_I2C_SPEED_CONFIG_COUNT];
-};
-
 struct soc_intel_skylake_config {
 	/*
 	 * Interrupt Routing configuration

-- 
To view, visit https://review.coreboot.org/19520
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icde4b7af5b9c31020099c1a6372a6867827f61ae
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>



More information about the coreboot-gerrit mailing list