[coreboot-gerrit] Change in coreboot[master]: util/intelmetool: Add bootguard information dump support

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/16328 )

Change subject: util/intelmetool: Add bootguard information dump support
......................................................................


Patch Set 19:

(3 comments)

https://review.coreboot.org/#/c/16328/19/util/intelmetool/intelmetool.c
File util/intelmetool/intelmetool.c:

Line 458: 	default:
you are changing default behaviour. You need to mention it in the commit message.


https://review.coreboot.org/#/c/16328/19/util/intelmetool/msr.c
File util/intelmetool/msr.c:

Line 50: 	} else {
remove else { } but keep perror(...


Line 56: 	return msr;
unreachable


-- 
To view, visit https://review.coreboot.org/16328
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeec8e20fa8efc35d7db4c6a84be1f118dccfc4a
Gerrit-PatchSet: 19
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Damien Zammit <damien at zamaudio.com>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Mathias Krause <minipli at googlemail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes