[coreboot-gerrit] Change in coreboot[master]: pci_device: add PCI device IDs for Intel platforms

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19541 )

Change subject: pci_device: add PCI device IDs for Intel platforms
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/19541/3/src/include/device/pci_ids.h
File src/include/device/pci_ids.h:

PS3, Line 2762: #define PCI_DEVICE_ID_INTEL_APOLLOLAKE_HECI1		0x5a9a
i was thinking to modify common cse code to use HECI1 rather using duplicate macro


-- 
To view, visit https://review.coreboot.org/19541
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eee9409df3e6dc326b60bc82c2b715c70e7debd
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes