[coreboot-gerrit] Change in coreboot[master]: lenovo/x60: Enable TPM

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/13410 )

Change subject: lenovo/x60: Enable TPM
......................................................................


Patch Set 8:

(2 comments)

https://review.coreboot.org/#/c/13410/8/src/mainboard/lenovo/x60/Kconfig
File src/mainboard/lenovo/x60/Kconfig:

Line 30: 	select MAINBOARD_HAS_LPC_TPM
again add select TPM for TPM1.2


https://review.coreboot.org/#/c/13410/8/src/mainboard/lenovo/x60/romstage.c
File src/mainboard/lenovo/x60/romstage.c:

PS8, Line 252: init_tpm
> Yes, that doesn’t work. No idea, if some ideas in `tpm.c` are missing, or w
You have to add the tpm device id in drivers/pc80/tpm.c see the top


-- 
To view, visit https://review.coreboot.org/13410
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e65b37507c111af1c0c56822327d5497f58f085
Gerrit-PatchSet: 8
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Denis Carikli <GNUtoo at no-log.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes