[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Use common I2C code from intelblocks

[Rizwan Qureshi (Code Review)]

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/19469 )

Change subject: soc/intel/skylake: Use common I2C code from intelblocks
......................................................................


Patch Set 6:

(2 comments)

https://review.coreboot.org/#/c/19469/8/src/soc/intel/skylake/chip.h
File src/soc/intel/skylake/chip.h:

PS8, Line 36: 
> duplicated values here with #define and Kconfig options. Why?
removed from the Kconfig


https://review.coreboot.org/#/c/19469/8/src/soc/intel/skylake/i2c.c
File src/soc/intel/skylake/i2c.c:

PS8, Line 27: int devfn = S
> const
Done


-- 
To view, visit https://review.coreboot.org/19469
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae7d13303090c72380534618741858502cc9ee33
Gerrit-PatchSet: 6
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes