[coreboot-gerrit] Change in coreboot[master]: intel/common/block/i2c: Add common block for I2C

[Rizwan Qureshi (Code Review)]

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/19468 )

Change subject: intel/common/block/i2c: Add common block for I2C
......................................................................


Patch Set 6:

(5 comments)

https://review.coreboot.org/#/c/19468/8/src/soc/intel/common/block/i2c/i2c.c
File src/soc/intel/common/block/i2c/i2c.c:

Line 148: static const unsigned short pci_device_ids[] = {
> too many new lines
Done


https://review.coreboot.org/#/c/19468/8/src/soc/intel/common/block/i2c/i2c_early.c
File src/soc/intel/common/block/i2c/i2c_early.c:

PS8, Line 66: 
> space between ) and {
Done


https://review.coreboot.org/#/c/19468/8/src/soc/intel/common/block/i2c/lpss_i2c.h
File src/soc/intel/common/block/i2c/lpss_i2c.h:

Line 79: 	MIN_SS_SCL_LOWTIME		= 4700,
> same line
Done


Line 84: 	MIN_FP_SCL_HIGHTIME		= 260,
> What about success? Same goes for comment above.
Done


https://review.coreboot.org/#/c/19468/8/src/soc/intel/common/block/include/intelblocks/lpss_i2c.h
File src/soc/intel/common/block/include/intelblocks/lpss_i2c.h:

PS8, Line 103: uration.
> bus?
Done


-- 
To view, visit https://review.coreboot.org/19468
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d91a04c22e181e3a995112cce6d5f0324130b81
Gerrit-PatchSet: 6
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes