[coreboot-gerrit] Change in coreboot[master]: mb/lenovo/x200: Make button on dock to undock work

Arthur Heymans (Code Review) gerrit at coreboot.org
Thu May 4 09:30:49 CEST 2017


Arthur Heymans has submitted this change and it was merged. ( https://review.coreboot.org/19539 )

Change subject: mb/lenovo/x200: Make button on dock to undock work
......................................................................


mb/lenovo/x200: Make button on dock to undock work

Fetched from vendor DSDT.

Change-Id: Ib74408802e977d9caabcb815c9cbd06bd8dbe395
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
Reviewed-on: https://review.coreboot.org/19539
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
Reviewed-by: Kevin Keijzer <kevin at librepractice.org>
Reviewed-by: Alexander Couzens <lynxis at fe80.eu>
---
M src/mainboard/lenovo/x200/acpi/dock.asl
1 file changed, 12 insertions(+), 2 deletions(-)

Approvals:
  Alexander Couzens: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  build bot (Jenkins): Verified
  Kevin Keijzer: Looks good to me, but someone else must approve



diff --git a/src/mainboard/lenovo/x200/acpi/dock.asl b/src/mainboard/lenovo/x200/acpi/dock.asl
index e2aa53e..0c7c9ab 100644
--- a/src/mainboard/lenovo/x200/acpi/dock.asl
+++ b/src/mainboard/lenovo/x200/acpi/dock.asl
@@ -51,7 +51,17 @@
 		Notify(\_SB.DOCK, 3)
 	}
 
+	Method(_Q37, 0, NotSerialized)
+	{
+		Notify(\_SB.DOCK, 0)
+	}
+
 	Method(_Q45, 0, NotSerialized)
+	{
+		Notify(\_SB.DOCK, 3)
+	}
+
+	Method(_Q50, 0, NotSerialized)
 	{
 		Notify(\_SB.DOCK, 3)
 	}
@@ -61,8 +71,8 @@
 		Notify(\_SB.DOCK, 0)
 	}
 
-	Method(_Q37, 0, NotSerialized)
+	Method(_Q5A, 0, NotSerialized)
 	{
-		Notify(\_SB.DOCK, 0)
+		Notify(\_SB.DOCK, 3)
 	}
 }

-- 
To view, visit https://review.coreboot.org/19539
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib74408802e977d9caabcb815c9cbd06bd8dbe395
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Kevin Keijzer <kevin at librepractice.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>



More information about the coreboot-gerrit mailing list