[coreboot-gerrit] Change in coreboot[master]: Documentation/Intel: Add vboot documentation

[Lee Leahy (Code Review)]

Lee Leahy has posted comments on this change. ( https://review.coreboot.org/19534 )

Change subject: Documentation/Intel: Add vboot documentation
......................................................................


Patch Set 2:

(6 comments)

https://review.coreboot.org/#/c/19534/2/Documentation/Intel/vboot.html
File Documentation/Intel/vboot.html:

PS2, Line 50: typically 1/4th of the SPI flash
> That's really platform specific. Do you think it actually matters to call t
Added platform specific


PS2, Line 92: key
> mention RSA since we're talking about key lengths?
Done


PS2, Line 215: COLLECT_TIMESTAMPS
> Is this just a side effect of how the code is written now? There's no real 
This may be a side effect of the current code, but is currently required to successfully build vboot.


PS2, Line 226: RAM
> SRAM?
Done


PS2, Line 251: be built several times
> built? It's just added to cbfstool in multiple cbfs regions.
Fixed


PS2, Line 282: 0x100,0x1000,0x7ce80,0x1000
> Add a description for the magic constants and what they do? the same is tur
Done


-- 
To view, visit https://review.coreboot.org/19534
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie17b8443772f596de0c9d8afe6f4ec3ac4d4fef8
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes