[coreboot-gerrit] Change in coreboot[master]: drivers/pc80/tpm: Fix missing tis_close() function and TPM d...

Philipp Deppenwiese (Code Review) gerrit at coreboot.org
Wed May 3 15:51:19 CEST 2017


Hello Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19535

to look at the new patch set (#3).

Change subject: drivers/pc80/tpm: Fix missing tis_close() function and TPM deactivation.
......................................................................

drivers/pc80/tpm: Fix missing tis_close() function and TPM deactivation.

tis_close() must be called after tis_open() otherwise the locked
locality isn't released and the sessions hangs.

The deactivate command of the TPM should be executed after
the startup is done. So that we can be sure that the TPM
exists and is functional.

Change-Id: I1a06f6a29015708e4bc1de6e6678827c28b84e98
Signed-off-by: Philipp Deppenwiese <zaolin at das-labor.org>
---
M src/drivers/pc80/tpm/romstage.c
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/19535/3
-- 
To view, visit https://review.coreboot.org/19535
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1a06f6a29015708e4bc1de6e6678827c28b84e98
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>



More information about the coreboot-gerrit mailing list