[coreboot-gerrit] Change in coreboot[master]: drivers/pc80/tpm: Fix missing tis_close() function and TPM d...

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/19535 )

Change subject: drivers/pc80/tpm: Fix missing tis_close() function and TPM deactivation.
......................................................................


Patch Set 1:

(2 comments)

@Patrick can you be more specific giving -2 for a change without any explanation and referenced line of code is somehow hard to understand

https://review.coreboot.org/#/c/19535/1//COMMIT_MSG
Commit Message:

PS1, Line 9: tis_close() must be called after tis_open() otherwise the locked
           : locality isn't released and the sessions hangs.
> My impression was that the Linux Kernel works fine with the TPMs used in re
Yes the implementation is broken by not calling tis_close() after the command are issued. The deactivate should be done after tis_init() / tis_open() which probes the tpm is called


Line 15: 
> Tested how?
Tested on a APU2 platform


-- 
To view, visit https://review.coreboot.org/19535
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a06f6a29015708e4bc1de6e6678827c28b84e98
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes