[coreboot-gerrit] Change in coreboot[master]: nb/intel/gm45: Set display backlight according to EDID string

Arthur Heymans (Code Review) gerrit at coreboot.org
Wed May 3 14:18:53 CEST 2017


Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19500 )

Change subject: nb/intel/gm45: Set display backlight according to EDID string
......................................................................


Patch Set 19:

> >> When does _this_ code get tested?
 > >
 > > what do you mean? like the values for displays?
 > 
 > No, I mean this exact commit. It obviously didn't compile, yet
 > stated
 > the added value is tested. So I presume you tested it with
 > different
 > code?

yes I modified a value and added another display a user tested, was a bit to hasty in doing so.
I'll do a last test now.

-- 
To view, visit https://review.coreboot.org/19500
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7bc0d453fac31e806852206ba2c895720b2c843
Gerrit-PatchSet: 19
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: No



More information about the coreboot-gerrit mailing list