[coreboot-gerrit] Change in coreboot[master]: nb/intel/gm45: Set display backlight according to EDID string

Arthur Heymans (Code Review) gerrit at coreboot.org
Wed May 3 13:52:45 CEST 2017


Hello Patrick Rudolph, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19500

to look at the new patch set (#19).

Change subject: nb/intel/gm45: Set display backlight according to EDID string
......................................................................

nb/intel/gm45: Set display backlight according to EDID string

Add some known good values for some thinkpads displays.

Known good means that at this pwm frequency the display is evenly lit
on all duty cycles, the display makes minimal to no noise at lower
duty cycles and the display does not flicker. This values differs from
vendor (which uses an obviously wrong display clock  (190MHz instead
of 320MHz) resulting in frequency more than 60% off the intended
value.

TESTED on Thinkpad X200 with edid ascii string in list and removed
from list to see if notice message is shown.

Change-Id: Id7bc0d453fac31e806852206ba2c895720b2c843
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/mainboard/lenovo/t400/Makefile.inc
A src/mainboard/lenovo/t400/blc.c
M src/mainboard/lenovo/x200/Makefile.inc
A src/mainboard/lenovo/x200/blc.c
M src/mainboard/roda/rk9/Makefile.inc
A src/mainboard/roda/rk9/blc.c
M src/northbridge/intel/gm45/chip.h
M src/northbridge/intel/gm45/gm45.h
M src/northbridge/intel/gm45/gma.c
9 files changed, 147 insertions(+), 6 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/19500/19
-- 
To view, visit https://review.coreboot.org/19500
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id7bc0d453fac31e806852206ba2c895720b2c843
Gerrit-PatchSet: 19
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>



More information about the coreboot-gerrit mailing list