[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Add Intel XDCI code support

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19428 )

Change subject: soc/intel/common/block: Add Intel XDCI code support
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/19428/1/src/soc/intel/common/block/include/intelblocks/xdci.h
File src/soc/intel/common/block/include/intelblocks/xdci.h:

Line 22: 
> one too many new lines?
Done


https://review.coreboot.org/#/c/19428/1/src/soc/intel/common/block/xdci/xdci.c
File src/soc/intel/common/block/xdci/xdci.c:

PS1, Line 33: 	0x5aaa, /* ApolloLake */
            : 	0x31aa, /* GLK */
            : 	0x9d30, /* SunRisePoint LP */
> I've mentioned this in other CLs. I think it'd be good to move all of these
Done


Line 42: 	.devices	 = pci_device_ids,
> It's interesting we're repeating the boiler plate and then only providing a
make sense, but only concern is that init/some APIs which may need to implement inside SOC as an overridden mechanism. Implementing those might be little tricky because of some many like this

static struct device_operations usb_xdci_ops = {
	.read_resources		= &pci_dev_read_resources,
	.set_resources		= &pci_dev_set_resources,
	.enable_resources	= &pci_dev_enable_resources,
#if (pci_device_ids == XDCI)
	.init			= soc_xdci_init,
#if (pci_device_ids == XHCI)
	.init			= soc_xhci_init,
#if (pci_device_ids == XYZZ)
	.init			= soc_xyzz_init,
};


-- 
To view, visit https://review.coreboot.org/19428
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cbc686a00c26b92be2847b6bd6c2e5aa5a690f7
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-HasComments: Yes