[coreboot-gerrit] Change in coreboot[master]: google/gru: skip usbphy1 setup for Scarlet
Philip Chen (Code Review)
gerrit at coreboot.org
Wed May 3 00:58:10 CEST 2017
Philip Chen has posted comments on this change. ( https://review.coreboot.org/19489 )
Change subject: google/gru: skip usbphy1 setup for Scarlet
......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/#/c/19489/3//COMMIT_MSG
Commit Message:
PS3, Line 2: philipchen
> This should say "Philip Chen". Can you double-check your git config?
Fixed my git config.
PS3, Line 7: scarlet/gru
> This would be better as "google/gru: ", probably, then you can keep the "Sc
Done
Line 8:
> Please mention the reason for skipping the setup.
Done
https://review.coreboot.org/#/c/19489/3/src/mainboard/google/gru/mainboard.c
File src/mainboard/google/gru/mainboard.c:
PS3, Line 309: {
> nit: can remove braces
Done
--
To view, visit https://review.coreboot.org/19489
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66e0d8a235cc9057964f7abca32bc692d41e88fd
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Philip Chen <philipchen at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philip Chen <philipchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list