[coreboot-gerrit] Change in coreboot[master]: lib/edid.c: Return value differentiates absent and non-confo...

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19502 )

Change subject: lib/edid.c: Return value differentiates absent and non-conformant
......................................................................


Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/19502/5/src/drivers/parade/ps8640/ps8640.c
File src/drivers/parade/ps8640/ps8640.c:

Line 50: 	if (decode_edid(edid, edid_size, out) != EDID_CONFORMANT) {
Why do all these have to be changed? Why not just carefully assign the new return values so that EDID_CONFORMANT is 0, EDID_NON_CONFORMANT is -1 and EDID_ABSENT is -2 or something (so that you can still use a blanket (decode_edid() < 0) to check for conformance).


-- 
To view, visit https://review.coreboot.org/19502
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id90aa210ff72092c4ab638a7bafb82bd11889bdc
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes