[coreboot-gerrit] Change in coreboot[master]: nb/intel/gm45/gma.c: Decode EDID before NGI path

Arthur Heymans (Code Review) gerrit at coreboot.org
Tue May 2 15:16:19 CEST 2017


Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19503 )

Change subject: nb/intel/gm45/gma.c: Decode EDID before NGI path
......................................................................


Patch Set 11:

(1 comment)

https://review.coreboot.org/#/c/19503/11/src/northbridge/intel/gm45/gma.c
File src/northbridge/intel/gm45/gma.c:

Line 606: 	if (physbase && pio_res && pio_res->base && lfb_res && lfb_res->base)
> ahem, invert the condition?
wups


-- 
To view, visit https://review.coreboot.org/19503
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a540b1d036a9f38b44fd004309601630861f6e7
Gerrit-PatchSet: 11
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list