[coreboot-gerrit] Change in coreboot[master]: nb/intel/gm45/gma.c: Decode EDID before NGI path

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19503 )

Change subject: nb/intel/gm45/gma.c: Decode EDID before NGI path
......................................................................


Patch Set 10:

(2 comments)

https://review.coreboot.org/#/c/19503/10/src/northbridge/intel/gm45/gma.c
File src/northbridge/intel/gm45/gma.c:

PS10, Line 583: 128
> Maybe define that in src/include/edid.h ?
can also be 256 for 2.0 edid although I have yet to come across those.


Line 716: 	/* Init graphics power management */
> I wonder how far you have to go back so this comment makes sense again ;)
gma.c was introduced in 6481e1052fa88a4dcfb7220775ff67ecd3c70384 and even there it does not make sense.


-- 
To view, visit https://review.coreboot.org/19503
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a540b1d036a9f38b44fd004309601630861f6e7
Gerrit-PatchSet: 10
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes