[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Clean up code by using common FAST_SPI mo...

Barnali Sarkar (Code Review) gerrit at coreboot.org
Tue May 2 12:03:22 CEST 2017


Hello Aaron Durbin, Subrata Banik, build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19055

to look at the new patch set (#23).

Change subject: soc/intel/skylake: Clean up code by using common FAST_SPI module
......................................................................

soc/intel/skylake: Clean up code by using common FAST_SPI module

This patch currently contains the following -
 1. Use SOC_INTEL_COMMON_BLOCK_FAST_SPI kconfig for common FAST_SPI code.
 2. Perform FAST_SPI programming by calling APIs from common FAST_SPI library.
 3. Use common FAST_SPI header file.

Change-Id: I4fc90504d322db70ed4ea644b1593cc0605b5fe8
Signed-off-by: Barnali Sarkar <barnali.sarkar at intel.com>
---
M src/soc/intel/skylake/Kconfig
M src/soc/intel/skylake/Makefile.inc
M src/soc/intel/skylake/bootblock/cpu.c
M src/soc/intel/skylake/bootblock/pch.c
M src/soc/intel/skylake/finalize.c
D src/soc/intel/skylake/flash_controller.c
M src/soc/intel/skylake/include/fsp11/soc/romstage.h
M src/soc/intel/skylake/include/fsp20/soc/romstage.h
D src/soc/intel/skylake/include/soc/flash_controller.h
M src/soc/intel/skylake/include/soc/pch.h
D src/soc/intel/skylake/include/soc/spi.h
M src/soc/intel/skylake/pch.c
M src/soc/intel/skylake/romstage/Makefile.inc
M src/soc/intel/skylake/romstage/romstage.c
D src/soc/intel/skylake/romstage/spi.c
M src/soc/intel/skylake/smihandler.c
16 files changed, 36 insertions(+), 859 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/19055/23
-- 
To view, visit https://review.coreboot.org/19055
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4fc90504d322db70ed4ea644b1593cc0605b5fe8
Gerrit-PatchSet: 23
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list