[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Add Intel common SMBus code

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/19372 )

Change subject: soc/intel/common/block: Add Intel common SMBus code
......................................................................


Patch Set 5:

(6 comments)

https://review.coreboot.org/#/c/19372/6//COMMIT_MSG
Commit Message:

PS6, Line 7: smbus
> SMBus [1]
Done


PS6, Line 10: 
            : *Smbus read/write byte APIs
            : *Common smbus initialization code
> Please add at least one space after the bullet points.
Done


https://review.coreboot.org/#/c/19372/6/src/soc/intel/common/block/include/intelblocks/smbus.h
File src/soc/intel/common/block/include/intelblocks/smbus.h:

Line 19: int do_smbus_read_byte(unsigned int smbus_base, unsigned int device,
> That’s obvious from the name, so the comment is redundant?
Done


https://review.coreboot.org/#/c/19372/6/src/soc/intel/common/block/smbus/Kconfig
File src/soc/intel/common/block/smbus/Kconfig:

PS6, Line 4: SMBUS
> SMBus
Done


https://review.coreboot.org/#/c/19372/6/src/soc/intel/common/block/smbus/smbus.c
File src/soc/intel/common/block/smbus/smbus.c:

PS6, Line 107: n
> Please use a tab. Now idea why this gets always copied.
Done


https://review.coreboot.org/#/c/19372/6/src/soc/intel/common/block/smbus/smbuslib.c
File src/soc/intel/common/block/smbus/smbuslib.c:

Line 14:  */
> Please add a blank line between the license and code.
Done


-- 
To view, visit https://review.coreboot.org/19372
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I936143a334c31937d557c6828e5876d35b133567
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamirbohra at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes