[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Add Intel common smbus code

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/19372 )

Change subject: soc/intel/common/block: Add Intel common smbus code
......................................................................


Patch Set 5:

(6 comments)

https://review.coreboot.org/#/c/19372/5/src/soc/intel/common/block/include/intelblocks/smbus.h
File src/soc/intel/common/block/include/intelblocks/smbus.h:

PS5, Line 21: do_smbus_write_byte
> These are very poor names for globally visible functions.
Done.Revised name in PS#6


PS5, Line 23: enable_smbus
> This is overly generic. While there are other cases like this in the tree. 
Done.Changed to smbus_common_init


https://review.coreboot.org/#/c/19372/5/src/soc/intel/common/block/smbus/smbus.c
File src/soc/intel/common/block/smbus/smbus.c:

PS5, Line 81: SMBUS_IO_BASE
> This is now being applied to all users of this module?
Yes. SMBUS IO base address is common to skylake/apollolake/glk and upcoming Intel SOCs.


Line 103: 	0xa123, /* SunRisePoint H */
> Add ids to pci_ids.h ?
ok. Do you suggest moving it to soc/pci_ids.h or define pci_ids.h under common?


https://review.coreboot.org/#/c/19372/5/src/soc/intel/common/block/smbus/smbuslib.c
File src/soc/intel/common/block/smbus/smbuslib.c:

PS5, Line 24: 0xefa0
> This is duplicated in more than one place?
Ok.move it to intelblocks/smbus.h?


Line 180: #if !ENV_RAMSTAGE
> Why are these functions being guarded?
There was definition conflict due to declaration under device/early_smbus.h and device/smbus.h for smbus_write_byte/smbus_read_byte functions,had to limit scope.


-- 
To view, visit https://review.coreboot.org/19372
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I936143a334c31937d557c6828e5876d35b133567
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamirbohra at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes