[coreboot-gerrit] Change in coreboot[master]: drivers/pc80/tpm: Enable TPM device unconditionally in ASL

[Tobias Diedrich (Code Review)]

Tobias Diedrich has posted comments on this change. ( https://review.coreboot.org/19235 )

Change subject: drivers/pc80/tpm: Enable TPM device unconditionally in ASL
......................................................................


Patch Set 6:

> > Does the tpm work?
 > > Did you run a selftest?
 > > Can you get owernership?
 > 
 > Could you please list the commands on how to test that? Right now,
 > judging from the Linux messages everything works on the Lenovo
 > X60t, besides sometimes resume, where the start-up is not done by
 > the coreboot.

tpm_selftest is part of the tpm-tools package.
Also this _might_ be helpful info:

"""
Initializing a TPM without the BIOS (for systems where the BIOS does not have TPM support).
I couldn't find any docs for this, so it required quite a bit of trial-and-error.

1) Install tpm-tools (and trousers)
2) Boot into single-user mode (trousers only allows you to software-assert physical presence in single-user mode)
3) tpm_setpresence --assert --well-known
4) tpm_setenable --enable --force
5) tpm_setactive --enable --well-known
6) reboot!
7) Your TPM should now be enabled and active.
"""

-- 
To view, visit https://review.coreboot.org/19235
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If057c49c3b80f6d43702e2971d3a8ff198f8d3cc
Gerrit-PatchSet: 6
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Raptor Engineering Automated Test Stand <noreply at raptorengineeringinc.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-Reviewer: coreboot org <coreboot.org at gmail.com>
Gerrit-HasComments: No