[coreboot-gerrit] Change in coreboot[master]: nb/intel/x4x/raminit: Remove very long delay

Arthur Heymans (Code Review) gerrit at coreboot.org
Tue May 2 10:06:11 CEST 2017


Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19514 )

Change subject: nb/intel/x4x/raminit: Remove very long delay
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/19514/2//COMMIT_MSG
Commit Message:

Line 8: 
> When you know, why the delay was added in the first place, please add that 
No idea actually. My best guess is that serialICE was slow at some point, but since I have never successfully used serialICE I don't know if that theory is possibly valid.

Fun fact: on resume from s3 with one dimm using i2c block read for spd it boots faster than that 250ms delay.


-- 
To view, visit https://review.coreboot.org/19514
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idff5b978bbf161f8520d8000848e7b11c98c3945
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list