[coreboot-gerrit] Change in coreboot[master]: mainboard/google/poppy: Add support for cr50 I2C TPM

[Vadim Bendebury (Code Review)]

Vadim Bendebury has posted comments on this change. ( https://review.coreboot.org/19518 )

Change subject: mainboard/google/poppy: Add support for cr50 I2C TPM
......................................................................


Patch Set 1:

(2 comments)

just a couple of nits/questions

https://review.coreboot.org/#/c/19518/1/src/mainboard/google/poppy/Kconfig
File src/mainboard/google/poppy/Kconfig:

PS1, Line 25: config DRIVER_TPM_I2C_BUS
            : 	default 0x1
            : 
            : config DRIVER_TPM_I2C_ADDR
            : 	default 0x50
            : 
should these be conditional on POPPY_USE_I2C_TPM being true?


https://review.coreboot.org/#/c/19518/1/src/mainboard/google/poppy/variants/baseboard/gpio.c
File src/mainboard/google/poppy/variants/baseboard/gpio.c:

PS1, Line 95: IS_ENABLED(CONFIG_POPPY_USE_SPI_TPM
aren't USE_SPI_TPM and USE_I2C_TPM mutually exclusive and one of them guaranteed to be present for Poppy? Maybe it is enough to combine this conditional compilation section and the next one (starting in line 161)


-- 
To view, visit https://review.coreboot.org/19518
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b293b8d410a6973a6dfea393c17d0be425b6a28
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes