[coreboot-gerrit] Change in coreboot[master]: nb/intel/gm45: Set display backlight according to EDID string

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19500 )

Change subject: nb/intel/gm45: Set display backlight according to EDID string
......................................................................


Patch Set 12:

(1 comment)

https://review.coreboot.org/#/c/19500/12/src/northbridge/intel/gm45/gma.c
File src/northbridge/intel/gm45/gma.c:

PS12, Line 762: gma_pm_init_post_vbios(dev, edid_lvds.ascii_string);
Should this indeed not run in the case of absent LVDS EDID or simply with an empty string?


-- 
To view, visit https://review.coreboot.org/19500
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7bc0d453fac31e806852206ba2c895720b2c843
Gerrit-PatchSet: 12
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes