[coreboot-gerrit] Change in coreboot[master]: nb/intel/gm45: Set display backlight according to EDID string

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19500 )

Change subject: nb/intel/gm45: Set display backlight according to EDID string
......................................................................


Patch Set 10:

> (7 comments)
 > 
 > Finally \o/
 > 
 > Regarding "known good", maybe add an option to use Vendor intended
 > vs.
 > coreboot recommended? It feels a little wrong to force values that
 > are
 > that far off the originals.

I'm ok with that. Should it be the value that option rom attempts to use (you can extract that with intel_bios_reader) or the value that option rom actually sets using 190MHz cdclock?

-- 
To view, visit https://review.coreboot.org/19500
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7bc0d453fac31e806852206ba2c895720b2c843
Gerrit-PatchSet: 10
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No