[coreboot-gerrit] Change in coreboot[master]: lib/edid: Save the display ASCII string

Arthur Heymans (Code Review) gerrit at coreboot.org
Mon May 1 19:26:14 CEST 2017


Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19499 )

Change subject: lib/edid: Save the display ASCII string
......................................................................


Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/19499/7/src/include/edid.h
File src/include/edid.h:

Line 92: 	char ascii_string[13];
> Needs additional space for null-termination.
So with 14 spaces it will be automatically null-terminated ,given that 13 byte EDID strings are not?


-- 
To view, visit https://review.coreboot.org/19499
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic31af53dcb9947e2264c809ee8f80ea4f89f347d
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list