[coreboot-gerrit] Change in coreboot[master]: nb/intel/gm45/gma.c: Decode EDID before NGI path

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19503 )

Change subject: nb/intel/gm45/gma.c: Decode EDID before NGI path
......................................................................


Patch Set 6:

(2 comments)

https://review.coreboot.org/#/c/19503/6/src/northbridge/intel/gm45/gma.c
File src/northbridge/intel/gm45/gma.c:

PS6, Line 669: gtt_res
> What if it's NULL?
allocator messed up? Should this be guarded against?


PS6, Line 687: 	printk(BIOS_DEBUG, "VGA EDID\n");
             : 	intel_gmbus_read_edid(mmio + GMBUS0, 2, 0x50, edid_data_vga,
             : 			sizeof(edid_data_vga));
             : 	intel_gmbus_stop(mmio + GMBUS0);
             : 	vga_edid_status = decode_edid(edid_data_vga,
             : 				sizeof(edid_data_vga), &edid_vga);
> I suppose it's only needed with NGI?
ah yes indeed.


-- 
To view, visit https://review.coreboot.org/19503
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a540b1d036a9f38b44fd004309601630861f6e7
Gerrit-PatchSet: 6
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes