[coreboot-gerrit] Change in coreboot[master]: lib/edid.c: Return value differentiates absent and non-confo...

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19502 )

Change subject: lib/edid.c: Return value differentiates absent and non-conformant
......................................................................


Patch Set 4:

(1 comment)

Some other code was using return value. Should those bail out on EDID_ABSENT or EDID_NOT_CONFORMANT ?

https://review.coreboot.org/#/c/19502/3/src/lib/edid.c
File src/lib/edid.c:

PS3, Line 1490: !c.conformant
> EDID_CONFORMANT == 0. This check isn't appropriate any more. There appears 
Thanks for spotting this.


-- 
To view, visit https://review.coreboot.org/19502
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id90aa210ff72092c4ab638a7bafb82bd11889bdc
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes