[coreboot-gerrit] Change in coreboot[master]: util/intelmetool: Fix access to deleted data on stack

Youness Alaoui (Code Review) gerrit at coreboot.org
Fri Mar 31 22:27:40 CEST 2017


Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/19066 )

Change subject: util/intelmetool: Fix access to deleted data on stack
......................................................................


Patch Set 1:

Note: This could have been fixed also by making 'namebuf' into a static variable, but I didn't think it was an elegant solution, so I modified it this way. the pci_me_interface_scan is a static function and not called anywhere else, so it seemed a good chance.
Also, I declared 'char namebuf[1024], *name;' on a single line because that's how it's declared in pci_platform_scan function, if it doesn't match the coding convention, I can change it.

-- 
To view, visit https://review.coreboot.org/19066
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I947a4c794ee37fe87e035593eaabcaf963b9875e
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: Youness Alaoui <snifikino at gmail.com>
Gerrit-HasComments: No



More information about the coreboot-gerrit mailing list