[coreboot-gerrit] Change in coreboot[master]: [UNTESTED]nb/i945/raminit: Use common ddr2 decode functions

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18305 )

Change subject: [UNTESTED]nb/i945/raminit: Use common ddr2 decode functions
......................................................................


Patch Set 28:

(2 comments)

> (2 comments)
 > 
 > Please, why don't you use SPD-Byte 12 for Refresh Rate?

That byte gets decoded into tRR.

https://review.coreboot.org/#/c/18305/28/src/northbridge/intel/i945/raminit.c
File src/northbridge/intel/i945/raminit.c:

PS28, Line 454: 2
> sorry, why is there an offset of 1 ?
That is how ranks gets decoded.


PS28, Line 564: sysinfo->refresh = 0;
              : 	if (max_tRR == 15625 * 256 / 2) {
              : 		sysinfo->refresh = 1;
> why don't you use SPD Byte 12: Refresh Rate?
I should make a constant for this to make it more clear.
that byte is being used here indirectly (decoded).


-- 
To view, visit https://review.coreboot.org/18305
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97c93939d11807752797785dd88c70b43a236ee3
Gerrit-PatchSet: 28
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-Reviewer: coreboot org <coreboot.org at gmail.com>
Gerrit-HasComments: Yes