[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Add Intel common UART code

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/18952 )

Change subject: soc/intel/common/block: Add Intel common UART code
......................................................................


Patch Set 7:

(4 comments)

https://review.coreboot.org/#/c/18952/7/src/soc/intel/common/block/include/intelblocks/uart.h
File src/soc/intel/common/block/include/intelblocks/uart.h:

PS7, Line 4: Copyright 2017 Intel Corporation.
header issue


PS7, Line 21: soc_uart_init
common code shouldn't have anything like "soc"


https://review.coreboot.org/#/c/18952/7/src/soc/intel/common/block/uart/uart.c
File src/soc/intel/common/block/uart/uart.c:

PS7, Line 20: device_t dev
can't we have dev as local


PS7, Line 33: 	/* Take UART out of reset */
            : 	write32(base + LPSS_RESET_CTL_REG, LPSS_CNT_RST_RELEASE);
            : 
            : 	/* Set M and N divisor inputs and enable clock */
            : 	clk_sel = LPSS_CLOCK_DIV_N(clk_n_val) | LPSS_CLOCK_DIV_M(clk_m_val);
            : 	write32(base + LPSS_CLOCK_CTL_REG, clk_sel | LPSS_CNT_CLK_UPDATE);
            : 	write32(base + LPSS_CLOCK_CTL_REG, clk_sel | LPSS_CNT_CLOCK_EN);
> Aren't these generic to all lpss blocks? including i2c and spi as well? If 
lets create a LPSS.c with a common LPSS block. then from i2c an spi, just API call


-- 
To view, visit https://review.coreboot.org/18952
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3843fac88cfb7bbb405be50d69f555b274f0d72a
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes