[coreboot-gerrit] Change in coreboot[master]: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC

[Mario Scheithauer (Code Review)]

Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/19043 )

Change subject: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC
......................................................................


Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/19043/1/src/mainboard/siemens/mc_apl1/lcd_panel.c
File src/mainboard/siemens/mc_apl1/lcd_panel.c:

PS1, Line 38: 
> Verb is spelled with a space *Set up*.
Done


Line 38
> Right, then I mean below, that `0x%x\n", status` is not needed.
lcd_panel.c no longer exists.
The function call ptn3460_init is placed directly into mainboard.c because the mainboard doesn’t need a selection of the connected panel. I changed it there.


-- 
To view, visit https://review.coreboot.org/19043
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8fa79bb608f1842f26c1af3d7bf4bb0513fa94d
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes