[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Add Intel common RTC code support

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/18558 )

Change subject: soc/intel/common/block: Add Intel common RTC code support
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/18558/3/src/soc/intel/common/block/rtc/rtc.c
File src/soc/intel/common/block/rtc/rtc.c:

PS3, Line 24: B_PCH_PCR_RTC_CONF_UCMOS_EN
> Actually these are in pcr_ids.h from the SoC. What is the purpose of this c
>>Either the IP is the same or its not

IP is same, so we are good to keep the code inside common block. 

>> If it is the same then provide the registers in this compilation unit and use it

if you see soc/pcr_id.h header between big core and small core, its majorly different because of Port ID (which make sense) but register wise RTC and ITSS are same, hence i thought of keeping those common registers into intelblocks/ but just 4-5 line common register set makes no value for a separate header. Hence i have decided to kept those common pieces also into respective soc/ directory. if you want i may pull those registers into this rtc.c file itself and remove from pcr_id.h alone in SKL and APL.


-- 
To view, visit https://review.coreboot.org/18558
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9dfcdbc300c25f43936d1efb5d6f9d81d3c8453
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes