[coreboot-gerrit] Change in coreboot[master]: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC

[Mario Scheithauer (Code Review)]

Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/19043 )

Change subject: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/19043/1/src/mainboard/siemens/mc_apl1/ptn3460.c
File src/mainboard/siemens/mc_apl1/ptn3460.c:

Line 28:  * @return CB_SUCCESS on success or CB_ERR on error.
> Done
I’ve start the change of the return value to the cb_err type. But after a short discussion with Werner we came to the conclusion that it would be better to use the previous version because of the possibility to make a distinction between different error messages. So we can faster see the current issue over debug message in a fault case. I would build it again back if you agree with that.


-- 
To view, visit https://review.coreboot.org/19043
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8fa79bb608f1842f26c1af3d7bf4bb0513fa94d
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes