[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Add Intel common PCR support

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/18669 )

Change subject: soc/intel/common/block: Add Intel common PCR support
......................................................................


Patch Set 5:

(3 comments)

https://review.coreboot.org/#/c/18669/5/src/soc/intel/common/block/include/intelblocks/pcr.h
File src/soc/intel/common/block/include/intelblocks/pcr.h:

PS5, Line 20: #include <stddef.h>
> What is this required for?
for size_t used in pcr.c


https://review.coreboot.org/#/c/18669/5/src/soc/intel/common/block/pcr/pcr.c
File src/soc/intel/common/block/pcr/pcr.c:

Line 112: 	read32(pcr_reg_address(pid, offset));
> Again, this is still wrong. offset could be misaligned. Therefore you shoul
as per PCH recommendation it should be a 32 bit dummy read, hence we could do something like this, to ensure its always a DWORD align address

read32(pcr_reg_address(pid, (offset & 0xFFFC)));

>> Also, why are you recalculating pcr_reg_address() ?
with above logic, now we again need to recalculate pcr address, isn't it?


PS5, Line 117: int 
> The fact that pcr_read32() and pcr_write32() are returning return codes is 
so, you are recommending to assert rather returning -1 because "caller" don't bother abut return parameter.


-- 
To view, visit https://review.coreboot.org/18669
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78526a86b6d10f226570c08050327557e0bb2c78
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-HasComments: Yes