[coreboot-gerrit] Change in coreboot[master]: util/futility/Makefile: Update clean target

Martin Roth (Code Review) gerrit at coreboot.org
Wed Mar 29 05:16:53 CEST 2017


Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/18998 )

Change subject: util/futility/Makefile: Update clean target
......................................................................


util/futility/Makefile: Update clean target

- Fix clean target to pass if output doesn't exist
- Make sure $(RM) is actually defined

Change-Id: Ibcdb0e329084f58b27c3f53213a237d02c922a51
Signed-off-by: Martin Roth <gaumless at gmail.com>
Reviewed-on: https://review.coreboot.org/18998
Reviewed-by: Aaron Durbin <adurbin at chromium.org>
Reviewed-by: Paul Kocialkowski <contact at paulk.fr>
Tested-by: build bot (Jenkins)
Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
M util/futility/Makefile
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Aaron Durbin: Looks good to me, approved
  Philippe Mathieu-Daudé: Looks good to me, but someone else must approve
  Paul Kocialkowski: Looks good to me, but someone else must approve
  Paul Menzel: Looks good to me, but someone else must approve
  build bot (Jenkins): Verified



diff --git a/util/futility/Makefile b/util/futility/Makefile
index 36f2b31..cce5da6 100644
--- a/util/futility/Makefile
+++ b/util/futility/Makefile
@@ -1,5 +1,6 @@
 top ?= $(abspath ../..)
 objutil ?= $(top)/util
+RM ?= rm
 
 HOSTCC ?= $(CC)
 VBOOT_SOURCE ?= $(top)/3rdparty/vboot
@@ -9,8 +10,8 @@
 
 .PHONY: clean
 clean:
-	$(RM) $(objutil)/futility/futility
-	$(RM) -r $(objutil)/futility/build
+	$(RM) -f $(objutil)/futility/futility
+	$(RM) -rf $(objutil)/futility/build
 
 distclean: clean
 

-- 
To view, visit https://review.coreboot.org/18998
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibcdb0e329084f58b27c3f53213a237d02c922a51
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Kocialkowski <contact at paulk.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list