[coreboot-gerrit] Change in coreboot[master]: src/lib/jpeg: Fix missing closing brace

[Youness Alaoui (Code Review)]

Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/19032 )

Change subject: src/lib/jpeg: Fix missing closing brace
......................................................................


Patch Set 1:

(3 comments)

I've trimmed down the commit message and fixed the stuff you mentioned.

https://review.coreboot.org/#/c/19032/1//COMMIT_MSG
Commit Message:

PS1, Line 7: accolade
> Not sure if it's generally called like that?
Oh, you're right, my mistake, I think it's "curly bracket" or "braces" in English. Accolade is a French term and I wasn't sure if it was correct, then forgot to check/confirm.


PS1, Line 15: https://review.coreboot.org/18761
> Mentioning the upstream commit would be easier to follow and is less
Good point, will do.


Line 18: that commit builds even though it didn't.
> It's only compiled with CONFIG_BOOTSPLASH being set.
Ah! That explains it. I thought the buildbot was building multiple configurations to test most of the code coverage. I guess it doesn't. Might be good to change it.


-- 
To view, visit https://review.coreboot.org/19032
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie10b774875fc25ce2ff613c542c15870e780a761
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes