[coreboot-gerrit] Change in coreboot[master]: src/lib/jpeg: Fix missing closing accolade

Youness Alaoui (Code Review) gerrit at coreboot.org
Tue Mar 28 22:25:55 CEST 2017


Youness Alaoui has uploaded a new change for review. ( https://review.coreboot.org/19032 )

Change subject: src/lib/jpeg: Fix missing closing accolade
......................................................................

src/lib/jpeg: Fix missing closing accolade

There's a missing closing accolade in fillbits function of jpeg.c.
This causes the 'if' block in line 463 to never be closed and it
will mistakenly think that the dec_readmakrer function declaration
below it is part of the fillbits function itself, which causes an
avalanche of compilation errors.

This was introduced in https://review.coreboot.org/18761 and it
prevents coreboot from building (after I did a make disclean).
For some reason the buildbot didn't seem to notice it and has verified
that commit builds even though it didn't.

Change-Id: Ie10b774875fc25ce2ff613c542c15870e780a761
Signed-off-by: Youness Alaoui <youness.alaoui at puri.sm>
---
M src/lib/jpeg.c
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/19032/1

diff --git a/src/lib/jpeg.c b/src/lib/jpeg.c
index 06827ea..7125396 100644
--- a/src/lib/jpeg.c
+++ b/src/lib/jpeg.c
@@ -464,6 +464,7 @@
 						m = in->func(in->data);
 						if (m == 0)
 							continue;
+                                        }
 				}
 				in->marker = m;
 				if (le <= 16)

-- 
To view, visit https://review.coreboot.org/19032
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie10b774875fc25ce2ff613c542c15870e780a761
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Youness Alaoui <snifikino at gmail.com>



More information about the coreboot-gerrit mailing list