[coreboot-gerrit] Change in coreboot[master]: abuild: Treat command line for recursive invocations as bash...

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/18975 )

Change subject: abuild: Treat command line for recursive invocations as bash array
......................................................................


Patch Set 3:

(3 comments)

currently the -t "vendor1/board1 vendor2/board2", doesn't work although I think that would be a good addition.

https://review.coreboot.org/#/c/18975/3/util/abuild/abuild
File util/abuild/abuild:

PS3, Line 19: ABUILD_DATE="Dec 6, 2016"
            : ABUILD_VERSION="0.10.01"
Do you think this change is worth updating the version and date?


PS3, Line 784: local num_targets=$(wc -w <<<$targets)
>From shellcheck

        local num_targets=$(wc -w <<<$targets)
              ^-- SC2155: Declare and assign separately to avoid masking return values.
                                     ^-- SC2086: Double quote to prevent globbing and word splitting.


PS3, Line 785: local cpus_per_target=$(((${cpus:-1} + $num_targets - 1) / $num_targets))
>From shellcheck:

        local cpus_per_target=$(((${cpus:-1} + $num_targets - 1) / $num_targets))
                                               ^-- SC2004: $/${} is unnecessary on arithmetic variables.
                                                                   ^-- SC2004: $/${} is unnecessary on arithmetic variables.


-- 
To view, visit https://review.coreboot.org/18975
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76a1c6456ef8ab21286fdc1636d659a3b76bc5d7
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes