[coreboot-gerrit] Change in coreboot[master]: KBL: Update FSP headers - upgrade to FSP.2.0.0
Subrata Banik (Code Review)
gerrit at coreboot.org
Tue Mar 28 17:10:21 CEST 2017
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19023 )
Change subject: KBL: Update FSP headers - upgrade to FSP.2.0.0
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/19023/3/src/vendorcode/intel/fsp/fsp2_0/skykabylake/ConfigBlock/CpuConfigFspData.h
File src/vendorcode/intel/fsp/fsp2_0/skykabylake/ConfigBlock/CpuConfigFspData.h:
PS3, Line 66: } Bits;
: UINT32 Uint32[2];
: } CPU_CONFIG_FSP_DATA;
why added space? don't we run clean up script?
https://review.coreboot.org/#/c/19023/3/src/vendorcode/intel/fsp/fsp2_0/skykabylake/FspmUpd.h
File src/vendorcode/intel/fsp/fsp2_0/skykabylake/FspmUpd.h:
PS3, Line 41: #include <MemInfoHob.h>
directory structure change
??
--
To view, visit https://review.coreboot.org/19023
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8ecea6fa5f4e7a72410f8da535ab9c4808b3482
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list