[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Clean up code by using common CAR init

Subrata Banik (Code Review) gerrit at coreboot.org
Tue Mar 28 15:04:57 CEST 2017


Hello Aaron Durbin, Barnali Sarkar, Paul Menzel, build bot (Jenkins), Furquan Shaikh, Martin Roth,

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/18555

to look at the new patch set (#26).

Change subject: soc/intel/apollolake: Clean up code by using common CAR init
......................................................................

soc/intel/apollolake: Clean up code by using common CAR init

This patch currently contains common CAR initialization
required in bootblock phase along with common MSR header -
1. Use SOC_INTEL_COMMON_BLOCK_CAR to have common CAR initialization
and CAR teardown.
2. Use common MSR header "intelblocks/msr.h" inside soc/cpu.h

Change-Id: I67f909f50a24f009b3e35388665251be1dde40f7
Signed-off-by: Subrata Banik <subrata.banik at intel.com>
---
M src/soc/intel/apollolake/Kconfig
M src/soc/intel/apollolake/Makefile.inc
D src/soc/intel/apollolake/bootblock/cache_as_ram.S
D src/soc/intel/apollolake/exit_car.S
M src/soc/intel/apollolake/include/soc/cpu.h
5 files changed, 17 insertions(+), 385 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/18555/26
-- 
To view, visit https://review.coreboot.org/18555
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I67f909f50a24f009b3e35388665251be1dde40f7
Gerrit-PatchSet: 26
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list