[coreboot-gerrit] Change in coreboot[master]: KBL: Update FSP headers - upgrade to FSP.2.0.0

[Barnali Sarkar (Code Review)]

Barnali Sarkar has posted comments on this change. ( https://review.coreboot.org/19023 )

Change subject: KBL: Update FSP headers - upgrade to FSP.2.0.0
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/19023/2/src/vendorcode/intel/fsp/fsp2_0/skykabylake/ConfigBlock/CpuConfigFspData.h
File src/vendorcode/intel/fsp/fsp2_0/skykabylake/ConfigBlock/CpuConfigFspData.h:

Line 69: 
There is no change here actually.


https://review.coreboot.org/#/c/19023/2/src/vendorcode/intel/fsp/fsp2_0/skykabylake/MemInfoHob.h
File src/vendorcode/intel/fsp/fsp2_0/skykabylake/MemInfoHob.h:

PS2, Line 206: EFI_HOB_GUID_TYPE EfiHobGuidType
This parameter should be skipped.
FSP should only publish the Raw data of the HOB, it should not include the HOB Header.


-- 
To view, visit https://review.coreboot.org/19023
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8ecea6fa5f4e7a72410f8da535ab9c4808b3482
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-HasComments: Yes