[coreboot-gerrit] Change in coreboot[master]: siemens/mc_apl1: Adjust gpio settings

Mario Scheithauer (Code Review) gerrit at coreboot.org
Tue Mar 28 10:47:17 CEST 2017


Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/18995 )

Change subject: siemens/mc_apl1: Adjust gpio settings
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/18995/2/src/mainboard/siemens/mc_apl1/brd_gpio.h
File src/mainboard/siemens/mc_apl1/brd_gpio.h:

Line 20:  * entries for each table. */
> As this is a multi-line comment outside a function, please use the elaborat
Yes of course, you are right. Thanks Paul!


-- 
To view, visit https://review.coreboot.org/18995
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f440e863c2e6f59298c500ac5aefa3b7386bcdf
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list