[coreboot-gerrit] Change in coreboot[master]: abuild: Treat command line for recursive invocations as bash...

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/18975 )

Change subject: abuild: Treat command line for recursive invocations as bash array
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/18975/2//COMMIT_MSG
Commit Message:

Line 18: a few boards in parallel.
> They had issues on the build servers where build the world took longer when
Right. I'm still keeping the same CPU count constraint (minus rounding, but I can also make it round down if that's a huge concern... I don't think it should be). I'm just optimizing the case where you have way more CPUs than boards to build. Previously, if you had 32 CPUs and tried to build 5 boards it would build them all in parallel but with 1 CPU each. With my patch, they will each invoke make with div_round_up(32, 5) == 7 CPUs. In a case where you build more boards than you have CPUs (like "build the world"), my patch shouldn't change anything (32 xargs processes with 1 CPU each).


https://review.coreboot.org/#/c/18975/2/util/abuild/abuild
File util/abuild/abuild:

PS2, Line 787: -c $cpus_per_target 
> Now you're changing the -c parameter to abuild?
This is replacing the hardcoded '-c 1' from above (which is why that can no longer be part of $cmdline). I'm calculating the optimal amount of CPUs per board down here and then using that number (rounded up, so the minimum would still be '-c 1').


-- 
To view, visit https://review.coreboot.org/18975
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76a1c6456ef8ab21286fdc1636d659a3b76bc5d7
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes