[coreboot-gerrit] Change in coreboot[master]: vboot: Compile bootmode.c conditionally based on CONFIG_VBOOT

Julius Werner (Code Review) gerrit at coreboot.org
Tue Mar 28 02:10:37 CEST 2017


Julius Werner has posted comments on this change. ( https://review.coreboot.org/18982 )

Change subject: vboot: Compile bootmode.c conditionally based on CONFIG_VBOOT
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/18982/2/src/vboot/vboot_common.h
File src/vboot/vboot_common.h:

Line 114: int vboot_recovery_mode_memory_retrain(void) { return 0; }
> Why not make these static inline?
Right, I should have.


-- 
To view, visit https://review.coreboot.org/18982
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If83e1b3e0f34f75c2395b4c464651e373724b2e6
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list