[coreboot-gerrit] Change in coreboot[master]: vboot: Remove VBOOT_DYNAMIC_WORK_BUFFER Kconfig option

Julius Werner (Code Review) gerrit at coreboot.org
Tue Mar 28 02:10:28 CEST 2017


Julius Werner has posted comments on this change. ( https://review.coreboot.org/18979 )

Change subject: vboot: Remove VBOOT_DYNAMIC_WORK_BUFFER Kconfig option
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/18979/1/src/vboot/vboot_loader.c
File src/vboot/vboot_loader.c:

Line 153: 	if (ENV_ROMSTAGE && IS_ENABLED(CONFIG_VBOOT_STARTS_IN_ROMSTAGE)) {
> If you are not going to support the following combination then you should m
Right, my later patch does that. I first wrote all of this in one go and then overlooked this dependency when I separated it into individual patches.

Are you okay with me just submitting these together, so I don't have to shuffle everything around again?


-- 
To view, visit https://review.coreboot.org/18979
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f953c8d2a8dcb3f65b07f548184d6dd0eb688fe
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list