[coreboot-gerrit] Change in coreboot[master]: drivers/storage: Fix data flow issues detected by checkpatch

Lee Leahy (Code Review) gerrit at coreboot.org
Mon Mar 27 23:56:11 CEST 2017


Hello Andrey Petrov, Aaron Durbin, Bora Guvendik, build bot (Jenkins), Martin Roth,

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19010

to look at the new patch set (#2).

Change subject: drivers/storage: Fix data flow issues detected by checkpatch
......................................................................

drivers/storage: Fix data flow issues detected by checkpatch

Fix the following error and warnings detected by checkpatch.pl:

ERROR: trailing statements should be on next line
WARNING: else is not generally useful after a break or return
WARNING: long udelay - prefer mdelay; see arch/arm/include/asm/delay.h

These change are expected to change the binary.

The following errors detected by checkpatch are false positives:
ERROR: need consistent spacing around '*' (ctx:WxV)
ERROR: Macros with complex values should be enclosed in parentheses

TEST=None

Change-Id: Ib55bb89196d81ffb3602a04664e5be3911096d8d
Signed-off-by: Lee Leahy <Leroy.P.Leahy at intel.com>
---
M src/drivers/storage/mmc.c
M src/drivers/storage/sdhci.c
M src/include/device/mmc.h
3 files changed, 10 insertions(+), 11 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/19010/2
-- 
To view, visit https://review.coreboot.org/19010
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib55bb89196d81ffb3602a04664e5be3911096d8d
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list